bnxt_en: Remove superfluous memset()
authorLi Heng <liheng40@huawei.com>
Thu, 30 Jul 2020 06:43:50 +0000 (14:43 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 31 Jul 2020 00:41:05 +0000 (17:41 -0700)
Fixes coccicheck warning:

./drivers/net/ethernet/broadcom/bnxt/bnxt.c:3730:19-37: WARNING:
dma_alloc_coherent use in stats -> hw_stats already zeroes out
memory,  so memset is not needed

dma_alloc_coherent use in status already zeroes out memory,
so memset is not needed

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Li Heng <liheng40@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt.c

index 2622d3c..31fb5a2 100644 (file)
@@ -3732,8 +3732,6 @@ static int bnxt_alloc_stats_mem(struct bnxt *bp, struct bnxt_stats_mem *stats,
        if (!stats->hw_stats)
                return -ENOMEM;
 
-       memset(stats->hw_stats, 0, stats->len);
-
        stats->sw_stats = kzalloc(stats->len, GFP_KERNEL);
        if (!stats->sw_stats)
                goto stats_mem_err;