power: supply: olpc_battery: force the le/be casts
authorLubomir Rintel <lkundrak@v3.sk>
Sat, 11 May 2019 08:56:14 +0000 (10:56 +0200)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Tue, 14 May 2019 21:17:56 +0000 (23:17 +0200)
The endianness of data returned from the EC depends on the particular EC
version determined at run time. Cast from little/big endian explicitey
in the routine that flips endianness to the native one to make sparse
happy.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Reported-by: kbuild test robot <lkp@intel.com>
Fixes: 76311b9a3295 ("power: supply: olpc_battery: Add OLPC XO 1.75 support")
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/olpc_battery.c

index c628d3a..7720e4c 100644 (file)
@@ -327,9 +327,9 @@ static int olpc_bat_get_voltage_max_design(union power_supply_propval *val)
 static u16 ecword_to_cpu(struct olpc_battery_data *data, u16 ec_word)
 {
        if (data->little_endian)
-               return le16_to_cpu(ec_word);
+               return le16_to_cpu((__force __le16)ec_word);
        else
-               return be16_to_cpu(ec_word);
+               return be16_to_cpu((__force __be16)ec_word);
 }
 
 /*********************************************************************
@@ -341,7 +341,7 @@ static int olpc_bat_get_property(struct power_supply *psy,
 {
        struct olpc_battery_data *data = power_supply_get_drvdata(psy);
        int ret = 0;
-       __be16 ec_word;
+       u16 ec_word;
        uint8_t ec_byte;
        __be64 ser_buf;