staging: wfx: drop useless check
authorJérôme Pouiller <jerome.pouiller@silabs.com>
Tue, 5 May 2020 12:37:46 +0000 (14:37 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 May 2020 11:26:40 +0000 (13:26 +0200)
Currently, the ISR check if bus->core is not NULL. But, it is a useless
check. bus->core is initialiased before to request IRQ and it is not
assigned to NULL when it is released.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200505123757.39506-5-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wfx/bus_sdio.c
drivers/staging/wfx/bus_spi.c

index c2e4bd1..0a63e76 100644 (file)
@@ -91,20 +91,13 @@ static void wfx_sdio_irq_handler(struct sdio_func *func)
 {
        struct wfx_sdio_priv *bus = sdio_get_drvdata(func);
 
-       if (bus->core)
-               wfx_bh_request_rx(bus->core);
-       else
-               WARN(!bus->core, "race condition in driver init/deinit");
+       wfx_bh_request_rx(bus->core);
 }
 
 static irqreturn_t wfx_sdio_irq_handler_ext(int irq, void *priv)
 {
        struct wfx_sdio_priv *bus = priv;
 
-       if (!bus->core) {
-               WARN(!bus->core, "race condition in driver init/deinit");
-               return IRQ_NONE;
-       }
        sdio_claim_host(bus->func);
        wfx_bh_request_rx(bus->core);
        sdio_release_host(bus->func);
index 61e99b0..03f95e6 100644 (file)
@@ -140,10 +140,6 @@ static irqreturn_t wfx_spi_irq_handler(int irq, void *priv)
 {
        struct wfx_spi_priv *bus = priv;
 
-       if (!bus->core) {
-               WARN(!bus->core, "race condition in driver init/deinit");
-               return IRQ_NONE;
-       }
        queue_work(system_highpri_wq, &bus->request_rx);
        return IRQ_HANDLED;
 }