gpio: aggregator: update gpiochip_fwd_setup_delay_line() parameters
authorThomas Richard <thomas.richard@bootlin.com>
Mon, 11 Aug 2025 13:25:48 +0000 (15:25 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 11 Aug 2025 13:39:31 +0000 (15:39 +0200)
Remove useless parameters of gpiochip_fwd_setup_delay_line().

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
Link: https://lore.kernel.org/r/20250811-aaeon-up-board-pinctrl-support-v9-5-29f0cbbdfb30@bootlin.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-aggregator.c

index 95415f9..cc54d19 100644 (file)
@@ -453,10 +453,11 @@ static int gpiochip_fwd_delay_of_xlate(struct gpio_chip *chip,
        return line;
 }
 
-static int gpiochip_fwd_setup_delay_line(struct device *dev, struct gpio_chip *chip,
-                                        struct gpiochip_fwd *fwd)
+static int gpiochip_fwd_setup_delay_line(struct gpiochip_fwd *fwd)
 {
-       fwd->delay_timings = devm_kcalloc(dev, chip->ngpio,
+       struct gpio_chip *chip = &fwd->chip;
+
+       fwd->delay_timings = devm_kcalloc(chip->parent, chip->ngpio,
                                          sizeof(*fwd->delay_timings),
                                          GFP_KERNEL);
        if (!fwd->delay_timings)
@@ -468,8 +469,7 @@ static int gpiochip_fwd_setup_delay_line(struct device *dev, struct gpio_chip *c
        return 0;
 }
 #else
-static int gpiochip_fwd_setup_delay_line(struct device *dev, struct gpio_chip *chip,
-                                        struct gpiochip_fwd *fwd)
+static int gpiochip_fwd_setup_delay_line(struct gpiochip_fwd *fwd)
 {
        return 0;
 }
@@ -571,7 +571,6 @@ static struct gpiochip_fwd *gpiochip_fwd_create(struct device *dev,
                                                unsigned long features)
 {
        struct gpiochip_fwd *fwd;
-       struct gpio_chip *chip;
        unsigned int i;
        int error;
 
@@ -579,8 +578,6 @@ static struct gpiochip_fwd *gpiochip_fwd_create(struct device *dev,
        if (IS_ERR(fwd))
                return fwd;
 
-       chip = &fwd->chip;
-
        for (i = 0; i < ngpios; i++) {
                error = gpiochip_fwd_desc_add(fwd, descs[i], i);
                if (error)
@@ -588,7 +585,7 @@ static struct gpiochip_fwd *gpiochip_fwd_create(struct device *dev,
        }
 
        if (features & FWD_FEATURE_DELAY) {
-               error = gpiochip_fwd_setup_delay_line(dev, chip, fwd);
+               error = gpiochip_fwd_setup_delay_line(fwd);
                if (error)
                        return ERR_PTR(error);
        }