MIPS: entry: Remove unneeded need_resched() loop
authorValentin Schneider <valentin.schneider@arm.com>
Fri, 15 Mar 2019 16:31:33 +0000 (16:31 +0000)
committerPaul Burton <paul.burton@mips.com>
Tue, 19 Mar 2019 22:25:45 +0000 (15:25 -0700)
Since the enabling and disabling of IRQs within preempt_schedule_irq()
is contained in a need_resched() loop, we don't need the outer arch
code loop.

Note that commit a18815abcdfd ("Use preempt_schedule_irq.") initially
removed the existing loop, but missed the final branch to restore_all.
Commit cdaed73afb61 ("Fix preemption bug.") missed that and reintroduced
the loop.

Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Paul Burton <paul.burton@mips.com>
Cc: James Hogan <jhogan@kernel.org>
Cc: linux-mips@vger.kernel.org
Signed-off-by: Paul Burton <paul.burton@mips.com>
Cc: linux-kernel@vger.kernel.org
arch/mips/kernel/entry.S

index d7de8ad..5469d43 100644 (file)
@@ -58,15 +58,14 @@ resume_kernel:
        local_irq_disable
        lw      t0, TI_PRE_COUNT($28)
        bnez    t0, restore_all
-need_resched:
        LONG_L  t0, TI_FLAGS($28)
        andi    t1, t0, _TIF_NEED_RESCHED
        beqz    t1, restore_all
        LONG_L  t0, PT_STATUS(sp)               # Interrupts off?
        andi    t0, 1
        beqz    t0, restore_all
-       jal     preempt_schedule_irq
-       b       need_resched
+       PTR_LA  ra, restore_all
+       j       preempt_schedule_irq
 #endif
 
 FEXPORT(ret_from_kernel_thread)