net: phy: mscc: remove unneeded parenthesis
authorQuentin Schulz <quentin.schulz@bootlin.com>
Mon, 8 Oct 2018 10:07:26 +0000 (12:07 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 8 Oct 2018 17:29:21 +0000 (10:29 -0700)
The == operator precedes the || operator, so we can remove the
parenthesis around (a == b) || (c == d).

The condition is rather explicit and short so removing the parenthesis
definitely does not make it harder to read.

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/mscc.c

index d304fb4..0ff7803 100644 (file)
@@ -300,7 +300,7 @@ static int vsc85xx_mdix_set(struct phy_device *phydev, u8 mdix)
        u16 reg_val;
 
        reg_val = phy_read(phydev, MSCC_PHY_BYPASS_CONTROL);
-       if ((mdix == ETH_TP_MDI) || (mdix == ETH_TP_MDI_X)) {
+       if (mdix == ETH_TP_MDI || mdix == ETH_TP_MDI_X) {
                reg_val |= (DISABLE_PAIR_SWAP_CORR_MASK |
                            DISABLE_POLARITY_CORR_MASK  |
                            DISABLE_HP_AUTO_MDIX_MASK);