i2c: bcm2835: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Wed, 2 Sep 2020 15:06:37 +0000 (17:06 +0200)
committerWolfram Sang <wsa@kernel.org>
Fri, 18 Sep 2020 21:02:03 +0000 (23:02 +0200)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-bcm2835.c

index 5dc5195..37443ed 100644 (file)
@@ -421,11 +421,9 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
                return PTR_ERR(i2c_dev->regs);
 
        mclk = devm_clk_get(&pdev->dev, NULL);
-       if (IS_ERR(mclk)) {
-               if (PTR_ERR(mclk) != -EPROBE_DEFER)
-                       dev_err(&pdev->dev, "Could not get clock\n");
-               return PTR_ERR(mclk);
-       }
+       if (IS_ERR(mclk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(mclk),
+                                    "Could not get clock\n");
 
        i2c_dev->bus_clk = bcm2835_i2c_register_div(&pdev->dev, mclk, i2c_dev);