net: ibm: emac: Switch to use dev_err_probe() helper
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 15 Sep 2022 11:42:12 +0000 (19:42 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 21 Sep 2022 12:50:03 +0000 (13:50 +0100)
dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ibm/emac/core.c

index 0a4d04a..9b08e41 100644 (file)
@@ -2979,11 +2979,9 @@ static int emac_init_config(struct emac_instance *dev)
 
        /* Read MAC-address */
        err = of_get_ethdev_address(np, dev->ndev);
-       if (err) {
-               if (err != -EPROBE_DEFER)
-                       dev_err(&dev->ofdev->dev, "Can't get valid [local-]mac-address from OF !\n");
-               return err;
-       }
+       if (err)
+               return dev_err_probe(&dev->ofdev->dev, err,
+                                    "Can't get valid [local-]mac-address from OF !\n");
 
        /* IAHT and GAHT filter parameterization */
        if (emac_has_feature(dev, EMAC_FTR_EMAC4SYNC)) {