drm/amdkfd: remove extra use of volatile
authorVictor Zhao <Victor.Zhao@amd.com>
Tue, 22 Oct 2024 13:48:13 +0000 (21:48 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 24 Oct 2024 22:04:49 +0000 (18:04 -0400)
as the adding of mb() should be sufficient in function unmap_queues_cpsch,
remove the add of volatile type as recommended

Signed-off-by: Victor Zhao <Victor.Zhao@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h

index 5a31837..38c19dc 100644 (file)
@@ -2048,7 +2048,7 @@ int amdkfd_fence_wait_timeout(struct device_queue_manager *dqm,
 {
        unsigned long end_jiffies = msecs_to_jiffies(timeout_ms) + jiffies;
        struct device *dev = dqm->dev->adev->dev;
-       volatile uint64_t *fence_addr = dqm->fence_addr;
+       uint64_t *fence_addr = dqm->fence_addr;
 
        while (*fence_addr != fence_value) {
                /* Fatal err detected, this response won't come */
index bddb169..09ab36f 100644 (file)
@@ -260,7 +260,7 @@ struct device_queue_manager {
        uint16_t                vmid_pasid[VMID_NUM];
        uint64_t                pipelines_addr;
        uint64_t                fence_gpu_addr;
-       volatile uint64_t       *fence_addr;
+       uint64_t                *fence_addr;
        struct kfd_mem_obj      *fence_mem;
        bool                    active_runlist;
        int                     sched_policy;