hwmon (lm63) Do not overwrite data->kind
authorNicolin Chen <nicoleotsuka@gmail.com>
Tue, 13 Nov 2018 04:36:56 +0000 (20:36 -0800)
committerGuenter Roeck <linux@roeck-us.net>
Sun, 16 Dec 2018 23:13:13 +0000 (15:13 -0800)
According to the code right before the removed line, data->kind
should be either from DT or from id pointer. So there shouldn't
be an additional overwriting after the if-else statement.

So this patch just removes the overwriting line.

Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/lm63.c

index 4c17709..eac54b9 100644 (file)
@@ -1120,7 +1120,6 @@ static int lm63_probe(struct i2c_client *client,
                data->kind = (enum chips)of_device_get_match_data(&client->dev);
        else
                data->kind = id->driver_data;
-       data->kind = id->driver_data;
        if (data->kind == lm64)
                data->temp2_offset = 16000;