drm/msm: dpu: Clear frame_busy_mask bit after trace
authorSean Paul <seanpaul@chromium.org>
Wed, 19 Sep 2018 18:33:48 +0000 (14:33 -0400)
committerRob Clark <robdclark@gmail.com>
Thu, 4 Oct 2018 00:24:53 +0000 (20:24 -0400)
We're printing the frame_busy_mask in a trace, but after it's been
cleared. This, as it turns out, is pretty pointless.

Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Rob Clark <robdclark@gmail.com>
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

index c2e8985..e56f291 100644 (file)
@@ -1361,9 +1361,9 @@ static void dpu_encoder_frame_done_callback(
                /* One of the physical encoders has become idle */
                for (i = 0; i < dpu_enc->num_phys_encs; i++) {
                        if (dpu_enc->phys_encs[i] == ready_phys) {
-                               clear_bit(i, dpu_enc->frame_busy_mask);
                                trace_dpu_enc_frame_done_cb(DRMID(drm_enc), i,
                                                dpu_enc->frame_busy_mask[0]);
+                               clear_bit(i, dpu_enc->frame_busy_mask);
                        }
                }