ath11k: fix memory leak on reg_info

Currently a return path is leaking the previously allocate reg_info. Fix
this by exiting via the return path mem_free.  Since the return value ret
is defaulted to 0, there is no need to re-assign ret to the 0 before
the goto.

Addresses-Coverity: ("Resource leak")
Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
index 473f676..0cc58d5 100644 (file)
--- a/drivers/net/wireless/ath/ath11k/wmi.c
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
@@ -4552,7 +4552,7 @@ static int ath11k_reg_chan_list_event(struct ath11k_base *ab, struct sk_buff *sk
        if (ab->default_regd[pdev_idx] && !ab->new_regd[pdev_idx] &&
            !memcmp((char *)ab->default_regd[pdev_idx]->alpha2,
                    (char *)reg_info->alpha2, 2))
-               return 0;
+               goto mem_free;
 
        /* Intersect new rules with default regd if a new country setting was
         * requested, i.e a default regd was already set during initialization