ata: libata-sff: make ata_resources_present() return 'bool'
authorSergey Shtylyov <s.shtylyov@omp.ru>
Sun, 13 Feb 2022 11:50:00 +0000 (14:50 +0300)
committerDamien Le Moal <damien.lemoal@opensource.wdc.com>
Sat, 19 Feb 2022 02:18:49 +0000 (11:18 +0900)
ata_resources_present() returns 1 if the primary/secondary channel's PCI
resources are present,  0 if not -- the 'bool' type fits somewhat better
here than 'int'...

Use the *= operator, while at it...

Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
drivers/ata/libata-sff.c

index 546b1f7..f5e4cd0 100644 (file)
@@ -2174,18 +2174,18 @@ EXPORT_SYMBOL_GPL(ata_sff_std_ports);
 
 #ifdef CONFIG_PCI
 
-static int ata_resources_present(struct pci_dev *pdev, int port)
+static bool ata_resources_present(struct pci_dev *pdev, int port)
 {
        int i;
 
        /* Check the PCI resources for this channel are enabled */
-       port = port * 2;
+       port *= 2;
        for (i = 0; i < 2; i++) {
                if (pci_resource_start(pdev, port + i) == 0 ||
                    pci_resource_len(pdev, port + i) == 0)
-                       return 0;
+                       return false;
        }
-       return 1;
+       return true;
 }
 
 /**