backlight: lm3630a_bl: Handle deferred probe
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tue, 5 Mar 2024 08:12:00 +0000 (09:12 +0100)
committerLee Jones <lee@kernel.org>
Thu, 7 Mar 2024 09:03:29 +0000 (09:03 +0000)
Don't pollute dmesg on deferred probe and simplify the code with
dev_err_probe().

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240305-backlight-probe-v2-5-609b0cf24bde@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/video/backlight/lm3630a_bl.c

index e6c0916..bb80ad5 100644 (file)
@@ -560,10 +560,9 @@ static int lm3630a_probe(struct i2c_client *client)
        /* pwm */
        if (pdata->pwm_ctrl != LM3630A_PWM_DISABLE) {
                pchip->pwmd = devm_pwm_get(pchip->dev, "lm3630a-pwm");
-               if (IS_ERR(pchip->pwmd)) {
-                       dev_err(&client->dev, "fail : get pwm device\n");
-                       return PTR_ERR(pchip->pwmd);
-               }
+               if (IS_ERR(pchip->pwmd))
+                       return dev_err_probe(&client->dev, PTR_ERR(pchip->pwmd),
+                                            "fail : get pwm device\n");
 
                pwm_init_state(pchip->pwmd, &pchip->pwmd_state);
        }