smb: client: simplify cifs_fscache_get_super_cookie()

Avoid redundant 'strlen()' and use the convenient 'strreplace()'
to simplify 'cifs_fscache_get_super_cookie()'.

Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/smb/client/fscache.c b/fs/smb/client/fscache.c
index 01424a5..9f66bbc 100644 (file)
--- a/fs/smb/client/fscache.c
+++ b/fs/smb/client/fscache.c
@@ -38,7 +38,6 @@ int cifs_fscache_get_super_cookie(struct cifs_tcon *tcon)
        struct TCP_Server_Info *server = tcon->ses->server;
        struct fscache_volume *vcookie;
        const struct sockaddr *sa = (struct sockaddr *)&server->dstaddr;
-       size_t slen, i;
        char *sharename;
        char *key;
        int ret = -ENOMEM;
@@ -73,10 +72,7 @@ int cifs_fscache_get_super_cookie(struct cifs_tcon *tcon)
                return PTR_ERR(sharename);
        }
 
-       slen = strlen(sharename);
-       for (i = 0; i < slen; i++)
-               if (sharename[i] == '/')
-                       sharename[i] = ';';
+       strreplace(sharename, '/', ';');
 
        key = kasprintf(GFP_KERNEL, "cifs,%pISpc,%s", sa, sharename);
        if (!key)