platform/x86: sony-laptop: Use scnprintf() for avoiding potential buffer overflow
authorTakashi Iwai <tiwai@suse.de>
Wed, 11 Mar 2020 09:07:39 +0000 (10:07 +0100)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 20 Mar 2020 12:44:47 +0000 (14:44 +0200)
Since snprintf() returns the would-be-output size instead of the
actual output size, the succeeding calls may go beyond the given
buffer limit.  Fix it by replacing with scnprintf().

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/sony-laptop.c

index fb088dd..51309f7 100644 (file)
@@ -827,10 +827,10 @@ static ssize_t sony_nc_handles_show(struct device *dev,
        int i;
 
        for (i = 0; i < ARRAY_SIZE(handles->cap); i++) {
-               len += snprintf(buffer + len, PAGE_SIZE - len, "0x%.4x ",
+               len += scnprintf(buffer + len, PAGE_SIZE - len, "0x%.4x ",
                                handles->cap[i]);
        }
-       len += snprintf(buffer + len, PAGE_SIZE - len, "\n");
+       len += scnprintf(buffer + len, PAGE_SIZE - len, "\n");
 
        return len;
 }
@@ -2187,10 +2187,10 @@ static ssize_t sony_nc_thermal_profiles_show(struct device *dev,
 
        for (cnt = 0; cnt < THM_PROFILE_MAX; cnt++) {
                if (!cnt || (th_handle->profiles & cnt))
-                       idx += snprintf(buffer + idx, PAGE_SIZE - idx, "%s ",
+                       idx += scnprintf(buffer + idx, PAGE_SIZE - idx, "%s ",
                                        snc_thermal_profiles[cnt]);
        }
-       idx += snprintf(buffer + idx, PAGE_SIZE - idx, "\n");
+       idx += scnprintf(buffer + idx, PAGE_SIZE - idx, "\n");
 
        return idx;
 }