Input: evdev - remove ->event() method
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 3 Jul 2024 21:37:48 +0000 (14:37 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 8 Jul 2024 23:22:48 +0000 (16:22 -0700)
Input core favors ->events() (batch) method over ->event() method
if the former is defined, so there is no point in defining evdev_event()
as it is never called. Remove it.

Reviewed-by: Jeff LaBundy <jeff@labundy.com>
Reviewed-by: Benjamin Tissoires <bentiss@kernel.org>
Link: https://lore.kernel.org/r/20240703213756.3375978-2-dmitry.torokhov@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/evdev.c

index 51e0c49..05abcd4 100644 (file)
@@ -308,17 +308,6 @@ static void evdev_events(struct input_handle *handle,
        rcu_read_unlock();
 }
 
-/*
- * Pass incoming event to all connected clients.
- */
-static void evdev_event(struct input_handle *handle,
-                       unsigned int type, unsigned int code, int value)
-{
-       struct input_value vals[] = { { type, code, value } };
-
-       evdev_events(handle, vals, 1);
-}
-
 static int evdev_fasync(int fd, struct file *file, int on)
 {
        struct evdev_client *client = file->private_data;
@@ -1418,7 +1407,6 @@ static const struct input_device_id evdev_ids[] = {
 MODULE_DEVICE_TABLE(input, evdev_ids);
 
 static struct input_handler evdev_handler = {
-       .event          = evdev_event,
        .events         = evdev_events,
        .connect        = evdev_connect,
        .disconnect     = evdev_disconnect,