alloc_tag: outline and export free_reserved_page()
authorSuren Baghdasaryan <surenb@google.com>
Wed, 17 Jul 2024 21:28:44 +0000 (14:28 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 26 Jul 2024 21:33:09 +0000 (14:33 -0700)
Outline and export free_reserved_page() because modules use it and it in
turn uses page_ext_{get|put} which should not be exported.  The same
result could be obtained by outlining {get|put}_page_tag_ref() but that
would have higher performance impact as these functions are used in more
performance critical paths.

Link: https://lkml.kernel.org/r/20240717212844.2749975-1-surenb@google.com
Fixes: dcfe378c81f7 ("lib: introduce support for page allocation tagging")
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202407080044.DWMC9N9I-lkp@intel.com/
Suggested-by: Christoph Hellwig <hch@infradead.org>
Suggested-by: Vlastimil Babka <vbabka@suse.cz>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Kees Cook <keescook@chromium.org>
Cc: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: Sourav Panda <souravpanda@google.com>
Cc: <stable@vger.kernel.org> [6.10]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
include/linux/mm.h
mm/page_alloc.c

index 4563b56..c4b238a 100644 (file)
@@ -3137,21 +3137,7 @@ extern void reserve_bootmem_region(phys_addr_t start,
                                   phys_addr_t end, int nid);
 
 /* Free the reserved page into the buddy system, so it gets managed. */
-static inline void free_reserved_page(struct page *page)
-{
-       if (mem_alloc_profiling_enabled()) {
-               union codetag_ref *ref = get_page_tag_ref(page);
-
-               if (ref) {
-                       set_codetag_empty(ref);
-                       put_page_tag_ref(ref);
-               }
-       }
-       ClearPageReserved(page);
-       init_page_count(page);
-       __free_page(page);
-       adjust_managed_page_count(page, 1);
-}
+void free_reserved_page(struct page *page);
 #define free_highmem_page(page) free_reserved_page(page)
 
 static inline void mark_page_reserved(struct page *page)
index 8337926..7ac8d61 100644 (file)
@@ -5815,6 +5815,23 @@ unsigned long free_reserved_area(void *start, void *end, int poison, const char
        return pages;
 }
 
+void free_reserved_page(struct page *page)
+{
+       if (mem_alloc_profiling_enabled()) {
+               union codetag_ref *ref = get_page_tag_ref(page);
+
+               if (ref) {
+                       set_codetag_empty(ref);
+                       put_page_tag_ref(ref);
+               }
+       }
+       ClearPageReserved(page);
+       init_page_count(page);
+       __free_page(page);
+       adjust_managed_page_count(page, 1);
+}
+EXPORT_SYMBOL(free_reserved_page);
+
 static int page_alloc_cpu_dead(unsigned int cpu)
 {
        struct zone *zone;