drm/tidss: Use devm_drm_dev_alloc
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 15 Apr 2020 07:39:58 +0000 (09:39 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 28 Apr 2020 13:57:56 +0000 (15:57 +0200)
Already using devm_drm_dev_init, so very simple replacment.

Tested-by: Jyri Sarha <jsarha@ti.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Jyri Sarha <jsarha@ti.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200415074034.175360-24-daniel.vetter@ffwll.ch
drivers/gpu/drm/tidss/tidss_drv.c

index ad449d1..7d4465d 100644 (file)
@@ -135,20 +135,13 @@ static int tidss_probe(struct platform_device *pdev)
 
        dev_dbg(dev, "%s\n", __func__);
 
-       /* Can't use devm_* since drm_device's lifetime may exceed dev's */
-       tidss = kzalloc(sizeof(*tidss), GFP_KERNEL);
-       if (!tidss)
-               return -ENOMEM;
+       tidss = devm_drm_dev_alloc(&pdev->dev, &tidss_driver,
+                                  struct tidss_device, ddev);
+       if (IS_ERR(tidss))
+               return PTR_ERR(tidss);
 
        ddev = &tidss->ddev;
 
-       ret = devm_drm_dev_init(&pdev->dev, ddev, &tidss_driver);
-       if (ret) {
-               kfree(ddev);
-               return ret;
-       }
-       drmm_add_final_kfree(ddev, tidss);
-
        tidss->dev = dev;
        tidss->feat = of_device_get_match_data(dev);