drm/amd/display: Add ETW logging for AUX failures
authorWyatt Wood <wyatt.wood@amd.com>
Mon, 12 Jul 2021 16:12:48 +0000 (12:12 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 27 Jul 2021 16:10:43 +0000 (12:10 -0400)
[Why]
Would like to identify the cause of AUX transactions failing
via ETW logs.

[How]
Add ETW logging for AUX failures.

Reviewed-by: Pavic Josip <Josip.Pavic@amd.com>
Acked-by: Solomon Chiu <solomon.chiu@amd.com>
Signed-off-by: Wyatt Wood <wyatt.wood@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dce/dce_aux.c

index 2fb88e5..058a935 100644 (file)
@@ -71,6 +71,8 @@ enum {
 #define DEFAULT_AUX_ENGINE_MULT   0
 #define DEFAULT_AUX_ENGINE_LENGTH 69
 
+#define DC_TRACE_LEVEL_MESSAGE(...) /* do nothing */
+
 static void release_engine(
        struct dce_aux *engine)
 {
@@ -743,5 +745,11 @@ bool dce_aux_transfer_with_retries(struct ddc_service *ddc,
 fail:
        if (!payload_reply)
                payload->reply = NULL;
+
+       DC_TRACE_LEVEL_MESSAGE(DAL_TRACE_LEVEL_ERROR,
+                               WPP_BIT_FLAG_DC_ERROR,
+                               "AUX transaction failed. Result: %d",
+                               operation_result);
+
        return false;
 }