net: dsa: realtek: add phylink_get_caps implementation
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Sat, 19 Aug 2023 11:11:06 +0000 (12:11 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sun, 20 Aug 2023 10:38:43 +0000 (11:38 +0100)
The user ports use RSGMII, but we don't have that, and DT doesn't
specify a phy interface mode, so phylib defaults to GMII. These support
1G, 100M and 10M with flow control. It is unknown whether asymetric
pause is supported at all speeds.

The CPU port uses MII/GMII/RGMII/REVMII by hardware pin strapping,
and support speeds specific to each, with full duplex only supported
in some modes. Flow control may be supported again by hardware pin
strapping, and theoretically is readable through a register but no
information is given in the datasheet for that.

So, we do a best efforts - and be lenient.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/realtek/rtl8366rb.c

index 25f8802..7868ef2 100644 (file)
@@ -1049,6 +1049,32 @@ static enum dsa_tag_protocol rtl8366_get_tag_protocol(struct dsa_switch *ds,
        return DSA_TAG_PROTO_RTL4_A;
 }
 
+static void rtl8366rb_phylink_get_caps(struct dsa_switch *ds, int port,
+                                      struct phylink_config *config)
+{
+       unsigned long *interfaces = config->supported_interfaces;
+       struct realtek_priv *priv = ds->priv;
+
+       if (port == priv->cpu_port) {
+               __set_bit(PHY_INTERFACE_MODE_MII, interfaces);
+               __set_bit(PHY_INTERFACE_MODE_GMII, interfaces);
+               /* REVMII only supports 100M FD */
+               __set_bit(PHY_INTERFACE_MODE_REVMII, interfaces);
+               /* RGMII only supports 1G FD */
+               phy_interface_set_rgmii(interfaces);
+
+               config->mac_capabilities = MAC_1000 | MAC_100 |
+                                          MAC_SYM_PAUSE;
+       } else {
+               /* RSGMII port, but we don't have that, and we don't
+                * specify in DT, so phylib uses the default of GMII
+                */
+               __set_bit(PHY_INTERFACE_MODE_GMII, interfaces);
+               config->mac_capabilities = MAC_1000 | MAC_100 | MAC_10 |
+                                          MAC_SYM_PAUSE | MAC_ASYM_PAUSE;
+       }
+}
+
 static void
 rtl8366rb_mac_link_up(struct dsa_switch *ds, int port, unsigned int mode,
                      phy_interface_t interface, struct phy_device *phydev,
@@ -1796,6 +1822,7 @@ static int rtl8366rb_detect(struct realtek_priv *priv)
 static const struct dsa_switch_ops rtl8366rb_switch_ops_smi = {
        .get_tag_protocol = rtl8366_get_tag_protocol,
        .setup = rtl8366rb_setup,
+       .phylink_get_caps = rtl8366rb_phylink_get_caps,
        .phylink_mac_link_up = rtl8366rb_mac_link_up,
        .phylink_mac_link_down = rtl8366rb_mac_link_down,
        .get_strings = rtl8366_get_strings,
@@ -1821,6 +1848,7 @@ static const struct dsa_switch_ops rtl8366rb_switch_ops_mdio = {
        .setup = rtl8366rb_setup,
        .phy_read = rtl8366rb_dsa_phy_read,
        .phy_write = rtl8366rb_dsa_phy_write,
+       .phylink_get_caps = rtl8366rb_phylink_get_caps,
        .phylink_mac_link_up = rtl8366rb_mac_link_up,
        .phylink_mac_link_down = rtl8366rb_mac_link_down,
        .get_strings = rtl8366_get_strings,