drm/tidss: Implement struct drm_plane_helper_funcs.atomic_enable
authorThomas Zimmermann <tzimmermann@suse.de>
Thu, 9 Feb 2023 15:41:07 +0000 (16:41 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Mon, 20 Feb 2023 14:20:45 +0000 (15:20 +0100)
Enable the primary plane for tidss hardware via atomic_enable.
Atomic helpers invoke this callback only when the plane becomes
active.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230209154107.30680-7-tzimmermann@suse.de
drivers/gpu/drm/tidss/tidss_plane.c

index 0b12405..6bdd6e4 100644 (file)
@@ -124,6 +124,16 @@ static void tidss_plane_atomic_update(struct drm_plane *plane,
        hw_videoport = to_tidss_crtc(new_state->crtc)->hw_videoport;
 
        dispc_plane_setup(tidss->dispc, tplane->hw_plane_id, new_state, hw_videoport);
+}
+
+static void tidss_plane_atomic_enable(struct drm_plane *plane,
+                                     struct drm_atomic_state *state)
+{
+       struct drm_device *ddev = plane->dev;
+       struct tidss_device *tidss = to_tidss(ddev);
+       struct tidss_plane *tplane = to_tidss_plane(plane);
+
+       dev_dbg(ddev->dev, "%s\n", __func__);
 
        dispc_plane_enable(tidss->dispc, tplane->hw_plane_id, true);
 }
@@ -151,6 +161,7 @@ static void drm_plane_destroy(struct drm_plane *plane)
 static const struct drm_plane_helper_funcs tidss_plane_helper_funcs = {
        .atomic_check = tidss_plane_atomic_check,
        .atomic_update = tidss_plane_atomic_update,
+       .atomic_enable = tidss_plane_atomic_enable,
        .atomic_disable = tidss_plane_atomic_disable,
 };