net: dsa: felix: flower: validate control flags
authorAsbjørn Sloth Tønnesen <ast@fiberby.net>
Wed, 17 Apr 2024 14:44:06 +0000 (14:44 +0000)
committerJakub Kicinski <kuba@kernel.org>
Fri, 19 Apr 2024 00:08:30 +0000 (17:08 -0700)
This driver currently doesn't support any control flags.

Use flow_rule_match_has_control_flags() to check for control flags,
such as can be set through `tc flower ... ip_flags frag`.

In case any control flags are masked, flow_rule_match_has_control_flags()
sets a NL extended error message, and we return -EOPNOTSUPP.

Only compile-tested.

Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
Link: https://lore.kernel.org/r/20240417144407.104241-1-ast@fiberby.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/ocelot/felix_vsc9959.c

index 3c5509e..85952d8 100644 (file)
@@ -1755,6 +1755,9 @@ static int vsc9959_stream_identify(struct flow_cls_offload *f,
              BIT_ULL(FLOW_DISSECTOR_KEY_ETH_ADDRS)))
                return -EOPNOTSUPP;
 
+       if (flow_rule_match_has_control_flags(rule, f->common.extack))
+               return -EOPNOTSUPP;
+
        if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_ETH_ADDRS)) {
                struct flow_match_eth_addrs match;