mt76: connac: unschedule mac_work before going to sleep
authorLorenzo Bianconi <lorenzo@kernel.org>
Wed, 21 Apr 2021 10:43:50 +0000 (12:43 +0200)
committerFelix Fietkau <nbd@nbd.name>
Wed, 21 Apr 2021 18:55:55 +0000 (20:55 +0200)
In order to wake the device less frequently and so reduce power
consumpation, unschedule mac_work before going to sleep

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7615/mac.c
drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c
drivers/net/wireless/mediatek/mt76/mt7921/mac.c

index d113756..f81a17d 100644 (file)
@@ -1912,6 +1912,8 @@ void mt7615_pm_wake_work(struct work_struct *work)
                        napi_schedule(&dev->mt76.napi[i]);
                mt76_connac_pm_dequeue_skbs(mphy, &dev->pm);
                mt76_queue_tx_cleanup(dev, dev->mt76.q_mcu[MT_MCUQ_WM], false);
+               ieee80211_queue_delayed_work(mphy->hw, &mphy->mac_work,
+                                            MT7615_WATCHDOG_TIME);
        }
 
        ieee80211_wake_queues(mphy->hw);
index 66f1667..b32f26c 100644 (file)
@@ -42,8 +42,10 @@ void mt76_connac_power_save_sched(struct mt76_phy *phy,
 
        pm->last_activity = jiffies;
 
-       if (!test_bit(MT76_STATE_PM, &phy->state))
+       if (!test_bit(MT76_STATE_PM, &phy->state)) {
+               cancel_delayed_work(&phy->mac_work);
                queue_delayed_work(dev->wq, &pm->ps_work, pm->idle_timeout);
+       }
 }
 EXPORT_SYMBOL_GPL(mt76_connac_power_save_sched);
 
index cd5661e..214bd18 100644 (file)
@@ -1404,6 +1404,8 @@ void mt7921_pm_wake_work(struct work_struct *work)
                        napi_schedule(&dev->mt76.napi[i]);
                mt76_connac_pm_dequeue_skbs(mphy, &dev->pm);
                mt7921_tx_cleanup(dev);
+               ieee80211_queue_delayed_work(mphy->hw, &mphy->mac_work,
+                                            MT7921_WATCHDOG_TIME);
        }
 
        ieee80211_wake_queues(mphy->hw);