lib/test_rhashtable: Remove set but unused variable 'insert_retries'
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Wed, 23 Nov 2022 09:37:02 +0000 (17:37 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 25 Nov 2022 08:09:12 +0000 (08:09 +0000)
Variable 'insert_retries' is not effectively used in the function, so
delete it.

lib/test_rhashtable.c:437:18: warning: variable 'insert_retries' set but not used.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3242
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
lib/test_rhashtable.c

index f2ba578..3ae3399 100644 (file)
@@ -434,7 +434,7 @@ out_free:
 static int __init test_rhashtable_max(struct test_obj *array,
                                      unsigned int entries)
 {
-       unsigned int i, insert_retries = 0;
+       unsigned int i;
        int err;
 
        test_rht_params.max_size = roundup_pow_of_two(entries / 8);
@@ -447,9 +447,7 @@ static int __init test_rhashtable_max(struct test_obj *array,
 
                obj->value.id = i * 2;
                err = insert_retry(&ht, obj, test_rht_params);
-               if (err > 0)
-                       insert_retries += err;
-               else if (err)
+               if (err < 0)
                        return err;
        }