ASN.1: mark expected switch fall-through
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 25 Jan 2019 20:46:46 +0000 (14:46 -0600)
committerGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 8 Apr 2019 23:39:28 +0000 (18:39 -0500)
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warnings:

lib/asn1_decoder.c:386:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
lib/asn1_decoder.c:449:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enabling
-Wimplicit-fallthrough.

Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
lib/asn1_decoder.c

index dc14bea..8f3d207 100644 (file)
@@ -385,6 +385,8 @@ next_op:
        case ASN1_OP_END_SET_ACT:
                if (unlikely(!(flags & FLAG_MATCHED)))
                        goto tag_mismatch;
+               /* fall through */
+
        case ASN1_OP_END_SEQ:
        case ASN1_OP_END_SET_OF:
        case ASN1_OP_END_SEQ_OF:
@@ -450,6 +452,8 @@ next_op:
                        pc += asn1_op_lengths[op];
                        goto next_op;
                }
+               /* fall through */
+
        case ASN1_OP_ACT:
                ret = actions[machine[pc + 1]](context, hdr, tag, data + tdp, len);
                if (ret < 0)