wifi: iwlwifi: use unsigned to silence a GCC 12 warning
authorJakub Kicinski <kuba@kernel.org>
Fri, 20 May 2022 19:43:17 +0000 (12:43 -0700)
committerJakub Kicinski <kuba@kernel.org>
Mon, 23 May 2022 00:23:06 +0000 (17:23 -0700)
GCC 12 says:

drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1076:37: warning: array subscript -1 is below array bounds of ‘struct iwl_mvm_tid_data[9]’ [-Warray-bounds]
 1076 |                 if (mvmsta->tid_data[tid].state != IWL_AGG_OFF)
      |                     ~~~~~~~~~~~~~~~~^~~~~

Whatever, tid is a bit from for_each_set_bit(), it's clearly unsigned.

Acked-by: Kalle Valo <kvalo@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/wireless/intel/iwlwifi/mvm/sta.c

index 406f0a5..bbb1522 100644 (file)
@@ -1058,7 +1058,7 @@ static bool iwl_mvm_remove_inactive_tids(struct iwl_mvm *mvm,
                                         unsigned long *unshare_queues,
                                         unsigned long *changetid_queues)
 {
-       int tid;
+       unsigned int tid;
 
        lockdep_assert_held(&mvmsta->lock);
        lockdep_assert_held(&mvm->mutex);