usb: gadget: net2272: skip BAR1 on error handling paths in probe
authorEvgeny Novikov <novikov@ispras.ru>
Wed, 15 Jul 2020 16:40:09 +0000 (19:40 +0300)
committerFelipe Balbi <balbi@kernel.org>
Fri, 24 Jul 2020 13:45:12 +0000 (16:45 +0300)
net2272_rdk1_probe() skips "i == 1" (BAR1) during allocation of
resources. The patch does this on error hanling paths as well.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
drivers/usb/gadget/udc/net2272.c

index fbbe625..44d1ea2 100644 (file)
@@ -2370,6 +2370,8 @@ net2272_rdk1_probe(struct pci_dev *pdev, struct net2272 *dev)
 
  err:
        while (--i >= 0) {
+               if (i == 1)
+                       continue;       /* BAR1 unused */
                iounmap(mem_mapped_addr[i]);
                release_mem_region(pci_resource_start(pdev, i),
                        pci_resource_len(pdev, i));