clk: mediatek: reset: Return regmap's error code

device_node_to_regmap() can return different errors, and it's better
practice to pass them to callers.

Clean up the hardcoded -EINVAL and use PTR_ERR(regmap) instead.

Signed-off-by: Fei Shao <fshao@chromium.org>
Link: https://lore.kernel.org/r/20240717115919.975474-1-fshao@chromium.org
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

diff --git a/drivers/clk/mediatek/reset.c b/drivers/clk/mediatek/reset.c
index 290ceda..f8c0fd0 100644 (file)
--- a/drivers/clk/mediatek/reset.c
+++ b/drivers/clk/mediatek/reset.c
@@ -138,7 +138,7 @@ int mtk_register_reset_controller(struct device_node *np,
        regmap = device_node_to_regmap(np);
        if (IS_ERR(regmap)) {
                pr_err("Cannot find regmap for %pOF: %pe\n", np, regmap);
-               return -EINVAL;
+               return PTR_ERR(regmap);
        }
 
        data = kzalloc(sizeof(*data), GFP_KERNEL);
@@ -198,7 +198,7 @@ int mtk_register_reset_controller_with_dev(struct device *dev,
        regmap = device_node_to_regmap(np);
        if (IS_ERR(regmap)) {
                dev_err(dev, "Cannot find regmap %pe\n", regmap);
-               return -EINVAL;
+               return PTR_ERR(regmap);
        }
 
        data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);