hwrng: cctrng - Use device-managed registration API
authorTian Tao <tiantao6@hisilicon.com>
Mon, 1 Mar 2021 02:43:48 +0000 (10:43 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 12 Mar 2021 13:04:00 +0000 (00:04 +1100)
Use devm_hwrng_register to get rid of manual unregistration.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/cctrng.c

index 7a293f2..0efb37a 100644 (file)
@@ -585,7 +585,7 @@ static int cctrng_probe(struct platform_device *pdev)
        atomic_set(&drvdata->pending_hw, 1);
 
        /* registration of the hwrng device */
-       rc = hwrng_register(&drvdata->rng);
+       rc = devm_hwrng_register(dev, &drvdata->rng);
        if (rc) {
                dev_err(dev, "Could not register hwrng device.\n");
                goto post_pm_err;
@@ -618,8 +618,6 @@ static int cctrng_remove(struct platform_device *pdev)
 
        dev_dbg(dev, "Releasing cctrng resources...\n");
 
-       hwrng_unregister(&drvdata->rng);
-
        cc_trng_pm_fini(drvdata);
 
        cc_trng_clk_fini(drvdata);