amdgpu/dm: don't use after free.
authorDave Airlie <airlied@redhat.com>
Tue, 3 Oct 2017 04:27:15 +0000 (14:27 +1000)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 6 Oct 2017 17:05:22 +0000 (13:05 -0400)
This dereference acrtc after freeing it.

Found by the kfree cocci script.

Signed-off-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index 61ccddd..4f89731 100644 (file)
@@ -3174,7 +3174,6 @@ int amdgpu_dm_crtc_init(struct amdgpu_display_manager *dm,
 fail:
        kfree(acrtc);
        kfree(cursor_plane);
-       acrtc->crtc_id = -1;
        return res;
 }