staging: wilc1000: Avoid GFP_KERNEL allocation from atomic context.
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Sun, 7 Apr 2019 12:58:43 +0000 (21:58 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 16 Apr 2019 11:15:54 +0000 (13:15 +0200)
Since wilc_set_multicast_list() is called with dev->addr_list_lock
spinlock held, we can't use GFP_KERNEL memory allocation.

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Fixes: e624c58cf8eb ("staging: wilc1000: refactor code to avoid use of wilc_set_multicast_list global")
Cc: Ajay Singh <ajay.kathat@microchip.com>
Reviewed-by: Adham Abozaeid <adham.abozaeid@microchip.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wilc1000/wilc_netdev.c

index 1787154..ba78c08 100644 (file)
@@ -708,7 +708,7 @@ static void wilc_set_multicast_list(struct net_device *dev)
                return;
        }
 
-       mc_list = kmalloc_array(dev->mc.count, ETH_ALEN, GFP_KERNEL);
+       mc_list = kmalloc_array(dev->mc.count, ETH_ALEN, GFP_ATOMIC);
        if (!mc_list)
                return;