crypto: caam - Fix the pointer passed to caam_qi_shutdown()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 15 Sep 2024 10:22:12 +0000 (12:22 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 5 Oct 2024 05:22:05 +0000 (13:22 +0800)
The type of the last parameter given to devm_add_action_or_reset() is
"struct caam_drv_private *", but in caam_qi_shutdown(), it is casted to
"struct device *".

Pass the correct parameter to devm_add_action_or_reset() so that the
resources are released as expected.

Fixes: f414de2e2fff ("crypto: caam - use devres to de-initialize QI")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/caam/qi.c

index f6111ee..8ed2bb0 100644 (file)
@@ -794,7 +794,7 @@ int caam_qi_init(struct platform_device *caam_pdev)
 
        caam_debugfs_qi_init(ctrlpriv);
 
-       err = devm_add_action_or_reset(qidev, caam_qi_shutdown, ctrlpriv);
+       err = devm_add_action_or_reset(qidev, caam_qi_shutdown, qidev);
        if (err)
                goto fail2;