net/mlx5: HWS, remove wrong deletion of the miss table list
authorYevgeny Kliteynik <kliteyn@nvidia.com>
Thu, 2 Jan 2025 18:14:06 +0000 (20:14 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 7 Jan 2025 00:33:40 +0000 (16:33 -0800)
Remove wrong cleanup of the old miss table list and
simplify the error flow in the function.

Signed-off-by: Yevgeny Kliteynik <kliteyn@nvidia.com>
Reviewed-by: Mark Bloch <mbloch@nvidia.com>
Reviewed-by: Itamar Gozlan <igozlan@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20250102181415.1477316-8-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/steering/hws/table.c

index 967d67e..ab12975 100644 (file)
@@ -478,15 +478,9 @@ int mlx5hws_table_set_default_miss(struct mlx5hws_table *tbl,
        if (old_miss_tbl)
                list_del_init(&tbl->default_miss.next);
 
-       old_miss_tbl = tbl->default_miss.miss_tbl;
-       if (old_miss_tbl)
-               list_del_init(&old_miss_tbl->default_miss.head);
-
        if (miss_tbl)
                list_add(&tbl->default_miss.next, &miss_tbl->default_miss.head);
 
-       mutex_unlock(&ctx->ctrl_lock);
-       return 0;
 out:
        mutex_unlock(&ctx->ctrl_lock);
        return ret;