selinux: Use kcalloc() in policydb_index()

Multiplications for the size determination of memory allocations
indicated that array data structures should be processed.
Thus use the corresponding function "kcalloc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Paul Moore <paul@paul-moore.com>

diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c
index 9c92f29..66b9a35 100644 (file)
--- a/security/selinux/ss/policydb.c
+++ b/security/selinux/ss/policydb.c
@@ -540,23 +540,23 @@ static int policydb_index(struct policydb *p)
 #endif
 
        rc = -ENOMEM;
-       p->class_val_to_struct =
-               kzalloc(p->p_classes.nprim * sizeof(*(p->class_val_to_struct)),
-                       GFP_KERNEL);
+       p->class_val_to_struct = kcalloc(p->p_classes.nprim,
+                                        sizeof(*p->class_val_to_struct),
+                                        GFP_KERNEL);
        if (!p->class_val_to_struct)
                goto out;
 
        rc = -ENOMEM;
-       p->role_val_to_struct =
-               kzalloc(p->p_roles.nprim * sizeof(*(p->role_val_to_struct)),
-                       GFP_KERNEL);
+       p->role_val_to_struct = kcalloc(p->p_roles.nprim,
+                                       sizeof(*p->role_val_to_struct),
+                                       GFP_KERNEL);
        if (!p->role_val_to_struct)
                goto out;
 
        rc = -ENOMEM;
-       p->user_val_to_struct =
-               kzalloc(p->p_users.nprim * sizeof(*(p->user_val_to_struct)),
-                       GFP_KERNEL);
+       p->user_val_to_struct = kcalloc(p->p_users.nprim,
+                                       sizeof(*p->user_val_to_struct),
+                                       GFP_KERNEL);
        if (!p->user_val_to_struct)
                goto out;