soc: imx: gpcv2: move reset assert after requesting domain power up
authorPeng Fan <peng.fan@nxp.com>
Mon, 10 May 2021 04:00:45 +0000 (12:00 +0800)
committerShawn Guo <shawnguo@kernel.org>
Thu, 27 May 2021 01:01:36 +0000 (09:01 +0800)
The i.MX8MM VPU power up sequence is a bit special, it must follow:
1. request power up
2. reset assert
3. reset deassert

This change in this patch will not affect other domains, because
the power domain default is in asserted state, unless bootloader
deassert the reset. It also applies to GPU power domain.

Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Tested-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
drivers/soc/imx/gpcv2.c

index 2490757..35bbb1b 100644 (file)
@@ -217,8 +217,6 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd)
                goto out_regulator_disable;
        }
 
-       reset_control_assert(domain->reset);
-
        if (domain->bits.pxx) {
                /* request the domain to power up */
                regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PUP_REQ,
@@ -241,6 +239,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd)
                                  GPC_PGC_CTRL_PCR);
        }
 
+       reset_control_assert(domain->reset);
+
        /* delay for reset to propagate */
        udelay(5);