thinkpad_acpi: signedness bugs getting current_mode
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 11 Mar 2015 09:34:50 +0000 (12:34 +0300)
committerDarren Hart <dvhart@linux.intel.com>
Sat, 14 Mar 2015 18:59:15 +0000 (11:59 -0700)
This needs to be signed for the error handling to work.  Valid modes are
small positive integers.

Fixes: b790ceeb0fd9 ('thinkpad_acpi: Add adaptive_kbd_mode sysfs attr')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-By: Bastien Nocera <hadess@hadess.net>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
drivers/platform/x86/thinkpad_acpi.c

index 56eaddc..024861d 100644 (file)
@@ -2938,7 +2938,7 @@ static ssize_t adaptive_kbd_mode_show(struct device *dev,
                           struct device_attribute *attr,
                           char *buf)
 {
-       u32 current_mode;
+       int current_mode;
 
        current_mode = adaptive_keyboard_get_mode();
        if (current_mode < 0)
@@ -3621,7 +3621,7 @@ static int adaptive_keyboard_get_next_mode(int mode)
 
 static bool adaptive_keyboard_hotkey_notify_hotkey(unsigned int scancode)
 {
-       u32 current_mode = 0;
+       int current_mode = 0;
        int new_mode = 0;
        int keycode;