dmaengine: sh: drop double zeroing
authorJulia Lawall <Julia.Lawall@inria.fr>
Sun, 20 Sep 2020 11:26:16 +0000 (13:26 +0200)
committerVinod Koul <vkoul@kernel.org>
Mon, 5 Oct 2020 04:48:08 +0000 (10:18 +0530)
sg_init_table zeroes its first argument, so the allocation of that argument
doesn't have to.

the semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x,n,flags;
@@

x =
- kcalloc
+ kmalloc_array
  (n,sizeof(*x),flags)
...
sg_init_table(x,n)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Link: https://lore.kernel.org/r/1600601186-7420-5-git-send-email-Julia.Lawall@inria.fr
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/sh/shdma-base.c

index 788d696..7f72b3f 100644 (file)
@@ -728,7 +728,7 @@ static struct dma_async_tx_descriptor *shdma_prep_dma_cyclic(
         * Allocate the sg list dynamically as it would consumer too much stack
         * space.
         */
-       sgl = kcalloc(sg_len, sizeof(*sgl), GFP_KERNEL);
+       sgl = kmalloc_array(sg_len, sizeof(*sgl), GFP_KERNEL);
        if (!sgl)
                return NULL;