platform/x86: i2c-multi-instantiate: Simplify with dev_err_probe()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 5 Nov 2020 11:05:28 +0000 (13:05 +0200)
committerHans de Goede <hdegoede@redhat.com>
Tue, 24 Nov 2020 10:25:19 +0000 (11:25 +0100)
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20201105110530.27888-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/i2c-multi-instantiate.c

index d92d9a9..ce4d921 100644 (file)
@@ -118,9 +118,8 @@ static int i2c_multi_inst_probe(struct platform_device *pdev)
                }
                multi->clients[i] = i2c_acpi_new_device(dev, i, &board_info);
                if (IS_ERR(multi->clients[i])) {
-                       ret = PTR_ERR(multi->clients[i]);
-                       if (ret != -EPROBE_DEFER)
-                               dev_err(dev, "Error creating i2c-client, idx %d\n", i);
+                       ret = dev_err_probe(dev, PTR_ERR(multi->clients[i]),
+                                           "Error creating i2c-client, idx %d\n", i);
                        goto error;
                }
        }