staging: r8188eu: remove psa, pda
authorMartin Kaiser <martin@kaiser.cx>
Sun, 3 Apr 2022 16:54:36 +0000 (18:54 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 4 Apr 2022 14:32:43 +0000 (16:32 +0200)
Remove the psa, pda variables. They are set and read only once.
We can use the ieee80211 helpers directly.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220403165438.357728-10-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_recv.c

index 75c0e0b..63ce664 100644 (file)
@@ -937,7 +937,7 @@ static int validate_recv_data_frame(struct adapter *adapter,
                                    struct recv_frame *precv_frame)
 {
        u8 bretry;
-       u8 *psa, *pda, *pbssid;
+       u8 *pbssid;
        struct sta_info *psta = NULL;
        u8 *ptr = precv_frame->rx_data;
        struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)precv_frame->rx_data;
@@ -946,15 +946,13 @@ static int validate_recv_data_frame(struct adapter *adapter,
        int ret;
 
        bretry = ieee80211_has_retry(hdr->frame_control);
-       pda = ieee80211_get_DA(hdr);
-       psa = ieee80211_get_SA(hdr);
 
        pbssid = get_hdr_bssid(ptr);
        if (!pbssid)
                return _FAIL;
 
-       memcpy(pattrib->dst, pda, ETH_ALEN);
-       memcpy(pattrib->src, psa, ETH_ALEN);
+       memcpy(pattrib->dst, ieee80211_get_DA(hdr), ETH_ALEN);
+       memcpy(pattrib->src, ieee80211_get_SA(hdr), ETH_ALEN);
 
        memcpy(pattrib->bssid, pbssid, ETH_ALEN);