IB/mlx5: Fix a NULL vs IS_ERR() check
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 20 Mar 2020 13:26:41 +0000 (16:26 +0300)
committerJason Gunthorpe <jgg@mellanox.com>
Tue, 24 Mar 2020 22:47:55 +0000 (19:47 -0300)
The kzalloc() function returns NULL, not error pointers.

Fixes: 30f2fe40c72b ("IB/mlx5: Introduce UAPIs to manage packet pacing")
Link: https://lore.kernel.org/r/20200320132641.GF95012@mwanda
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/mlx5/qos.c

index f822b06..cac878a 100644 (file)
@@ -46,8 +46,8 @@ static int UVERBS_HANDLER(MLX5_IB_METHOD_PP_OBJ_ALLOC)(
 
        dev = to_mdev(c->ibucontext.device);
        pp_entry = kzalloc(sizeof(*pp_entry), GFP_KERNEL);
-       if (IS_ERR(pp_entry))
-               return PTR_ERR(pp_entry);
+       if (!pp_entry)
+               return -ENOMEM;
 
        in_ctx = uverbs_attr_get_alloced_ptr(attrs,
                                             MLX5_IB_ATTR_PP_OBJ_ALLOC_CTX);