drm/msm/hdmi: drop clock frequency assignment
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Mon, 5 May 2025 00:14:49 +0000 (03:14 +0300)
committerDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Mon, 12 May 2025 16:18:48 +0000 (19:18 +0300)
The only clock which has frequency being set through hpd_freqs is the
"core" aka MDSS_HDMI_CLK clock. It always has the specified frequency,
so we can drop corresponding clk_set_rate() call together with the
hpd_freq infrastructure.

Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/651717/
Link: https://lore.kernel.org/r/20250505-fd-hdmi-hpd-v5-5-48541f76318c@oss.qualcomm.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
drivers/gpu/drm/msm/hdmi/hdmi.c
drivers/gpu/drm/msm/hdmi/hdmi.h
drivers/gpu/drm/msm/hdmi/hdmi_hpd.c

index 104f9ce..6f09920 100644 (file)
@@ -234,12 +234,10 @@ static const struct hdmi_platform_config hdmi_tx_8960_config = {
 
 static const char * const pwr_reg_names_8x74[] = {"core-vdda", "core-vcc"};
 static const char * const hpd_clk_names_8x74[] = {"iface", "core", "mdp_core", "alt_iface"};
-static unsigned long hpd_clk_freq_8x74[] = {0, 19200000, 0, 0};
 
 static const struct hdmi_platform_config hdmi_tx_8974_config = {
                HDMI_CFG(pwr_reg, 8x74),
                HDMI_CFG(hpd_clk, 8x74),
-               .hpd_freq      = hpd_clk_freq_8x74,
 };
 
 static int msm_hdmi_bind(struct device *dev, struct device *master, void *data)
index 3314bb8..e93d49d 100644 (file)
@@ -93,7 +93,6 @@ struct hdmi_platform_config {
 
        /* clks that need to be on for hpd: */
        const char * const *hpd_clk_names;
-       const long unsigned *hpd_freq;
        int hpd_clk_cnt;
 };
 
index 9ce0ffa..7ae69b1 100644 (file)
@@ -68,15 +68,6 @@ static void enable_hpd_clocks(struct hdmi *hdmi, bool enable)
 
        if (enable) {
                for (i = 0; i < config->hpd_clk_cnt; i++) {
-                       if (config->hpd_freq && config->hpd_freq[i]) {
-                               ret = clk_set_rate(hdmi->hpd_clks[i],
-                                                  config->hpd_freq[i]);
-                               if (ret)
-                                       dev_warn(dev,
-                                                "failed to set clk %s (%d)\n",
-                                                config->hpd_clk_names[i], ret);
-                       }
-
                        ret = clk_prepare_enable(hdmi->hpd_clks[i]);
                        if (ret) {
                                DRM_DEV_ERROR(dev,