mm/memory_hotplug: don't use __GFP_HARDWALL when migrating pages via memory offlining
authorDavid Hildenbrand <david@redhat.com>
Thu, 5 Dec 2024 09:05:08 +0000 (10:05 +0100)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 14 Jan 2025 06:40:53 +0000 (22:40 -0800)
We'll migrate pages allocated by other context; respecting the cpuset of
the memory offlining context when allocating a migration target does not
make sense.

Drop the __GFP_HARDWALL by using GFP_KERNEL.

Note that in an ideal world, migration code could figure out the cpuset
of the original context and take that into consideration.

Link: https://lkml.kernel.org/r/20241205090508.2095225-3-david@redhat.com
Signed-off-by: David Hildenbrand <david@redhat.com>
Suggested-by: Vlastimil Babka <vbabka@suse.cz>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Acked-by: Oscar Salvador <osalvador@suse.de>
Cc: Zi Yan <ziy@nvidia.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/memory_hotplug.c

index 5f497cc..3b6f939 100644 (file)
@@ -1838,7 +1838,7 @@ put_folio:
                nodemask_t nmask = node_states[N_MEMORY];
                struct migration_target_control mtc = {
                        .nmask = &nmask,
-                       .gfp_mask = GFP_USER | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL,
+                       .gfp_mask = GFP_KERNEL | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL,
                        .reason = MR_MEMORY_HOTPLUG,
                };
                int ret;