drm/xe: Suspend/resume user access only during system s/r
authorImre Deak <imre.deak@intel.com>
Fri, 23 Aug 2024 11:21:46 +0000 (14:21 +0300)
committerVinod Govindapillai <vinod.govindapillai@intel.com>
Fri, 23 Aug 2024 19:10:54 +0000 (22:10 +0300)
Enable/Disable user access only during system suspend/resume.
This should not happen during runtime s/r

v2: rebased

Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240823112148.327015-2-vinod.govindapillai@intel.com
drivers/gpu/drm/xe/display/xe_display.c

index 30dfdac..ad7fc51 100644 (file)
@@ -323,7 +323,8 @@ void xe_display_pm_suspend(struct xe_device *xe, bool runtime)
        intel_fbdev_set_suspend(&xe->drm, FBINFO_STATE_SUSPENDED, true);
        if (has_display(xe)) {
                drm_kms_helper_poll_disable(&xe->drm);
-               intel_display_driver_disable_user_access(xe);
+               if (!runtime)
+                       intel_display_driver_disable_user_access(xe);
        }
 
        if (!runtime)
@@ -335,7 +336,7 @@ void xe_display_pm_suspend(struct xe_device *xe, bool runtime)
 
        intel_hpd_cancel_work(xe);
 
-       if (has_display(xe))
+       if (!runtime && has_display(xe))
                intel_display_driver_suspend_access(xe);
 
        intel_encoder_suspend_all(&xe->display);
@@ -381,7 +382,7 @@ void xe_display_pm_resume(struct xe_device *xe, bool runtime)
        intel_display_driver_init_hw(xe);
        intel_hpd_init(xe);
 
-       if (has_display(xe))
+       if (!runtime && has_display(xe))
                intel_display_driver_resume_access(xe);
 
        /* MST sideband requires HPD interrupts enabled */
@@ -391,7 +392,8 @@ void xe_display_pm_resume(struct xe_device *xe, bool runtime)
 
        if (has_display(xe)) {
                drm_kms_helper_poll_enable(&xe->drm);
-               intel_display_driver_enable_user_access(xe);
+               if (!runtime)
+                       intel_display_driver_enable_user_access(xe);
        }
        intel_hpd_poll_disable(xe);