hwmon: (ltc4282) remove the use of dev_err_probe()
authorLiao Yuanhong <liaoyuanhong@vivo.com>
Wed, 20 Aug 2025 13:15:08 +0000 (21:15 +0800)
committerGuenter Roeck <linux@roeck-us.net>
Sun, 7 Sep 2025 23:33:47 +0000 (16:33 -0700)
Logging messages that show some type of "out of memory" error are generally
unnecessary as there is a generic message and a stack dump done by the
memory subsystem. These messages generally increase kernel size without
much added value[1].

The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore,
remove the useless call to dev_err_probe(), and just return the value
instead.

[1]: https://lore.kernel.org/lkml/1402419340.30479.18.camel@joe-AO725/

Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
Link: https://lore.kernel.org/r/20250820131509.502007-1-liaoyuanhong@vivo.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/ltc4282.c

index dbb30ab..1d664a2 100644 (file)
@@ -1693,8 +1693,7 @@ static int ltc4282_probe(struct i2c_client *i2c)
 
        st = devm_kzalloc(dev, sizeof(*st), GFP_KERNEL);
        if (!st)
-               return dev_err_probe(dev, -ENOMEM,
-                                    "Failed to allocate memory\n");
+               return -ENOMEM;
 
        st->map = devm_regmap_init_i2c(i2c, &ltc4282_regmap_config);
        if (IS_ERR(st->map))