iio: adc: stm32: Fix missing return in booster error path
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 10 Sep 2020 08:52:07 +0000 (10:52 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 13 Sep 2020 09:43:55 +0000 (10:43 +0100)
Conversion of error paths to dev_err_probe() dropped one return
statement.  The driver will continue to probe if getting booster
regulator fails.

Fixes: ce30eeb613cb ("iio: adc: stm32: Simplify with dev_err_probe()")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/1599727927-7776-1-git-send-email-krzk@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/stm32-adc-core.c

index 3f27b48..6a0338d 100644 (file)
@@ -595,7 +595,7 @@ static int stm32_adc_core_switches_probe(struct device *dev,
                if (IS_ERR(priv->booster)) {
                        ret = PTR_ERR(priv->booster);
                        if (ret != -ENODEV)
-                               dev_err_probe(dev, ret, "can't get booster\n");
+                               return dev_err_probe(dev, ret, "can't get booster\n");
 
                        priv->booster = NULL;
                }