cifs: remove unnecessary tracing after put tcon
authorShyam Prasad N <sprasad@microsoft.com>
Sat, 14 Feb 2026 07:35:50 +0000 (13:05 +0530)
committerSteve French <stfrench@microsoft.com>
Sun, 15 Feb 2026 01:31:32 +0000 (19:31 -0600)
This code was recently changed from manually decrementing
tcon ref to using cifs_put_tcon. But even before that change
this tracing happened after decrementing the ref count, which
is wrong. With cifs_put_tcon, tracing already happens inside it.
So just removing the extra tracing here.

Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/smb2ops.c
fs/smb/client/trace.h

index 1e13dd0..61c5217 100644 (file)
@@ -3181,8 +3181,6 @@ smb2_get_dfs_refer(const unsigned int xid, struct cifs_ses *ses,
        if (tcon && !tcon->ipc) {
                /* ipc tcons are not refcounted */
                cifs_put_tcon(tcon, netfs_trace_tcon_ref_put_dfs_refer);
-               trace_smb3_tcon_ref(tcon->debug_id, tcon->tc_count,
-                                   netfs_trace_tcon_ref_dec_dfs_refer);
        }
        kfree(utf16_path);
        kfree(dfs_req);
index 191f023..9228f95 100644 (file)
        E_(cifs_trace_rw_credits_zero_in_flight,        "ZERO-IN-FLT")
 
 #define smb3_tcon_ref_traces                                         \
-       EM(netfs_trace_tcon_ref_dec_dfs_refer,          "DEC DfsRef") \
        EM(netfs_trace_tcon_ref_free,                   "FRE       ") \
        EM(netfs_trace_tcon_ref_free_fail,              "FRE Fail  ") \
        EM(netfs_trace_tcon_ref_free_ipc,               "FRE Ipc   ") \