pwm: lp3943: Fix an incorrect type in lp3943_pwm_parse_dt()
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Fri, 9 Aug 2024 08:05:23 +0000 (16:05 +0800)
committerUwe Kleine-König <ukleinek@kernel.org>
Mon, 16 Sep 2024 13:23:36 +0000 (15:23 +0200)
The return value from the call to of_property_count_u32_elems() is int.
However, the return value is being assigned to an u32 variable
'num_outputs', so making 'num_outputs' an int.

./drivers/pwm/pwm-lp3943.c:238:6-17: WARNING: Unsigned expression compared with zero: num_outputs <= 0.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9710
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Fixes: 75f0cb339b78 ("pwm: lp3943: Use of_property_count_u32_elems() to get property length")
Link: https://lore.kernel.org/r/20240809080523.32717-1-jiapeng.chong@linux.alibaba.com
Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
drivers/pwm/pwm-lp3943.c

index f0e94c9..90b0733 100644 (file)
@@ -218,8 +218,7 @@ static int lp3943_pwm_parse_dt(struct device *dev,
        struct lp3943_platform_data *pdata;
        struct lp3943_pwm_map *pwm_map;
        enum lp3943_pwm_output *output;
-       int i, err, count = 0;
-       u32 num_outputs;
+       int i, err, num_outputs, count = 0;
 
        if (!node)
                return -EINVAL;