drm/xe: Return immediately on tile_init failure
authorRodrigo Vivi <rodrigo.vivi@intel.com>
Wed, 6 Mar 2024 20:31:10 +0000 (15:31 -0500)
committerThomas Hellström <thomas.hellstrom@linux.intel.com>
Thu, 7 Mar 2024 08:13:38 +0000 (09:13 +0100)
There's no reason to proceed with applying workaround and initing
sysfs if we are going to abort the probe upon failure.

Fixes: e5a845fd8fa4 ("drm/xe: Add sysfs entry for tile")
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240306203110.146387-1-rodrigo.vivi@intel.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
(cherry picked from commit af7b93d1d7eeeef674681ddea875be6a29857a5d)
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
drivers/gpu/drm/xe/xe_tile.c

index 044c208..0650b2f 100644 (file)
@@ -167,9 +167,10 @@ int xe_tile_init_noalloc(struct xe_tile *tile)
                goto err_mem_access;
 
        tile->mem.kernel_bb_pool = xe_sa_bo_manager_init(tile, SZ_1M, 16);
-       if (IS_ERR(tile->mem.kernel_bb_pool))
+       if (IS_ERR(tile->mem.kernel_bb_pool)) {
                err = PTR_ERR(tile->mem.kernel_bb_pool);
-
+               goto err_mem_access;
+       }
        xe_wa_apply_tile_workarounds(tile);
 
        xe_tile_sysfs_init(tile);