staging: r8188eu: Remove unnecessary ret variable in rtw_drv_init()
authorNathan Chancellor <nathan@kernel.org>
Fri, 13 Aug 2021 20:14:18 +0000 (13:14 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 16 Aug 2021 07:08:47 +0000 (09:08 +0200)
ret is unnecessary as both error paths set the same error code so just
return that directly.

Suggested-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Reviewed-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Acked-by: Phillip Potter <phil@philpotter.co.uk>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20210813201418.4018631-1-nathan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/os_dep/usb_intf.c

index 667f411..3e5f4b5 100644 (file)
@@ -705,22 +705,18 @@ static int rtw_drv_init(struct usb_interface *pusb_intf, const struct usb_device
 {
        struct adapter *if1 = NULL;
        struct dvobj_priv *dvobj;
-       int ret;
 
        /* step 0. */
        process_spec_devid(pdid);
 
        /* Initialize dvobj_priv */
        dvobj = usb_dvobj_init(pusb_intf);
-       if (!dvobj) {
-               ret = -ENODEV;
+       if (!dvobj)
                goto err;
-       }
 
        if1 = rtw_usb_if1_init(dvobj, pusb_intf);
        if (!if1) {
                DBG_88E("rtw_init_primarystruct adapter Failed!\n");
-               ret = -ENODEV;
                goto free_dvobj;
        }
 
@@ -734,7 +730,7 @@ static int rtw_drv_init(struct usb_interface *pusb_intf, const struct usb_device
 free_dvobj:
        usb_dvobj_deinit(pusb_intf);
 err:
-       return ret;
+       return -ENODEV;
 }
 
 /*